Conversation
ErichDonGubler
left a comment
There was a problem hiding this comment.
I'm inclined to Move Fast and Cover Things™ for tests, but the API changes seem like something we may not want to (stably) expose for downstreams. CC @gfx-rs/wgpu for thoughts on that specifically.
|
Update on review from my end: I plan on getting to this before the end of the week, but it's not my highest priority. Hopefully, it won't have a lot of competition. 🤞🏻 |
|
@ErichDonGubler Ok, this PR is in kinda a limbo right now anyway. It would need a couple texture format fixes to land before we actually start breaking the CI and testing on everybody's machines. Plus I think a lot of it is probably already covered by the CTS. Make of that what you will. |
d471f75 to
5d919b8
Compare
|
Glad you didn't plan on keeping any of those commits intact! 😅 It let me easily force-push a squashed history on top of |
|
Aggh I really need to start using this whole "squash and force push" thing you guys are constantly doing. |
c8300da to
1978d63
Compare
|
Okay, so, I spent a bunch of time reviewing this, and after a mildly insane experiment, I pushed 1978d63 on top of what's already here, which uses @kpreid's suggestion to derive everything using I'm gonna put this back into draft; there are definitely some issues that need to be resolved. In rough order of importance that I see:
I'm gonna put these issues in your court, but I'm happy to help with (3) and review any fix PRs that can be broken out for (1) and (2). |
|
@ErichDonGubler I've reached out to you on Matrix. I'd also like to link #8670 as a sort of list of texture format issues I've ran into. |
Connections
Closes #8646
See also #8670
CI Failures mostly represent wgpu bugs, not issues with this PR
Description
Adds some testing for texture formats to make sure that what a device claims to support it actually supports
Testing
Is test
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.