Skip to content

Texture format testing#8653

Draft
inner-daemons wants to merge 4 commits intogfx-rs:trunkfrom
inner-daemons:texture-format-testing
Draft

Texture format testing#8653
inner-daemons wants to merge 4 commits intogfx-rs:trunkfrom
inner-daemons:texture-format-testing

Conversation

@inner-daemons
Copy link
Collaborator

@inner-daemons inner-daemons commented Dec 4, 2025

Connections
Closes #8646

See also #8670

CI Failures mostly represent wgpu bugs, not issues with this PR

Description

Adds some testing for texture formats to make sure that what a device claims to support it actually supports

Testing
Is test

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to Move Fast and Cover Things™ for tests, but the API changes seem like something we may not want to (stably) expose for downstreams. CC @gfx-rs/wgpu for thoughts on that specifically.

@ErichDonGubler
Copy link
Member

Update on review from my end: I plan on getting to this before the end of the week, but it's not my highest priority. Hopefully, it won't have a lot of competition. 🤞🏻

@inner-daemons
Copy link
Collaborator Author

@ErichDonGubler Ok, this PR is in kinda a limbo right now anyway. It would need a couple texture format fixes to land before we actually start breaking the CI and testing on everybody's machines. Plus I think a lot of it is probably already covered by the CTS. Make of that what you will.

@ErichDonGubler
Copy link
Member

ErichDonGubler commented Jan 28, 2026

Glad you didn't plan on keeping any of those commits intact! 😅 It let me easily force-push a squashed history on top of trunk just now.

@inner-daemons
Copy link
Collaborator Author

Aggh I really need to start using this whole "squash and force push" thing you guys are constantly doing.

@ErichDonGubler
Copy link
Member

Okay, so, I spent a bunch of time reviewing this, and after a mildly insane experiment, I pushed 1978d63 on top of what's already here, which uses @kpreid's suggestion to derive everything using macro_rules_attribute::derive. PTAL!

I'm gonna put this back into draft; there are definitely some issues that need to be resolved. In rough order of importance that I see:

  1. Figure out why tests are failing.
  2. Figure out why tests are OOM-ing, at least on my machine.
  3. Make test enumeration less prone to manual error. Having to list a test per texture format sounds problematic enough that it's worth figuring out if there's another way to do it before merging, methinks.

I'm gonna put these issues in your court, but I'm happy to help with (3) and review any fix PRs that can be broken out for (1) and (2).

@ErichDonGubler ErichDonGubler marked this pull request as draft January 28, 2026 22:35
@inner-daemons
Copy link
Collaborator Author

@ErichDonGubler I've reached out to you on Matrix. I'd also like to link #8670 as a sort of list of texture format issues I've ran into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing for texture formats

4 participants